(docs): slarify serviceMonitor basicAuth comment - Githubissues

dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.

https://helm.irsigler.cloud

GNU General Public License v3.0

144 stars 49 forks source link

(docs): slarify serviceMonitor basicAuth comment #127

Closed elmariofredo closed 10 months ago

elmariofredo commented 10 months ago

Description of the change

make it clear in values.yaml that user has to specify username as well

Benefits

user won't get confused by failing scraping

Possible drawbacks

none

Applicable issues

none

Additional information

See my proposed changes to kuma wiki https://github.com/louislam/uptime-kuma-wiki/compare/master...elmariofredo:uptime-kuma-wiki:patch-1

Checklist

As this is purely documentation change I think it's not necessary to release new version, WDYT?

[ ] Chart version bumped in Chart.yaml according to semver.
[ ] Variables are documented in the README.md

dirsigler commented 10 months ago

I agree that a new version is not really needed. Thank you 😊