search

dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.
https://helm.irsigler.cloud
GNU General Public License v3.0
144 stars 49 forks source link

feat: add option to mount additional existing volumes #128

Closed nobbs closed 10 months ago

nobbs commented 10 months ago

Description of the change

Adds the option to specify additional volumes and volume mounts that will be passed to the Deployment or StatefulSet. This feature might be used to provide Uptime Kuma with additional certificate authorities based on https://github.com/louislam/uptime-kuma/issues/1380 given the CA files in a configmap.

Benefits

Ability to mount additional files / folders / volumes into the Uptime Kuma pod.

Possible drawbacks

--

Applicable issues

--

Additional information

Checklist

dirsigler commented 10 months ago

Hey @nobbs , seems like a cool feature addition. By any chance you were able or could be able to test this feature out somehow?

This kind of feature (volumes) unfortunately is not covered by the GitHub Actions workflow with the KinD cluster.

nobbs commented 10 months ago

I did manually by setting the values and running helm template. I can look into testing it automatically as part of the CI tomorrow.

dirsigler commented 10 months ago

Hey, Additional CI/CD Tests are not needed from my side, but if got something quick up I am obviously happy about it.

Was more thinking if you have some local cluster up where you can test the functionality 😅.

Sitting at a conference currently so could earliest check it out today evening on my own.