search

dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.
https://helm.irsigler.cloud
GNU General Public License v3.0
144 stars 49 forks source link

feat: make access mode configurable with default option #150

Open fuse opened 6 months ago

fuse commented 6 months ago

Description of the change

It should be possible to set the pvc as rwx for instance. If no value has been set it will use rwo as default.

Benefits

Being able to deploy with rwx storage.

Possible drawbacks

Someone could configure it wrong but then he could just remove its custom value.

Applicable issues

Cluster with several worker and the willing to be able to deploy kuma on any, mostly for fault tolerance.

Additional information

Value was already documented as usable in README but is not. I didn’t upgrade version as this minor fix could be part of larger release.

Checklist

lesmyrmidons commented 5 months ago

👍

dirsigler commented 5 months ago

Hey @fuse ,

thanks for this contribution and your patience! Could you please rebase the latest changes from main and also then bump the ChartVersion in your branch here.

You could afterwards also run helm-docs . to update the README.md file with your changes. Afterwards the PR will probably look fine!