fix livenessProbe - Githubissues

dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.

https://helm.irsigler.cloud

GNU General Public License v3.0

144 stars 49 forks source link

fix livenessProbe #169

Closed dirsigler closed 1 week ago

dirsigler commented 1 week ago

Description of the change

Make livenessProbe and readinessProbe configurable
Provide sane default values
Remove again "node" command from livenessProbe

Benefits

Fix deployment.

Possible drawbacks

N/A

Applicable issues

fixes #168

Additional information

The "node" healthcheck is deprecated and should not be used. The merge of previous PR which implemented this was a mistake. https://github.com/louislam/uptime-kuma/blob/ae224f9e188b1fc32ed8729818710975589cdce7/extra/healthcheck.js#L6

A default delay of 180 seconds is recommend by Uptime-Kuma until the healthcheck command is called. https://github.com/louislam/uptime-kuma/blob/ae224f9e188b1fc32ed8729818710975589cdce7/extra/healthcheck.go#L3

Checklist

[X] Chart version bumped in Chart.yaml according to semver.
[X] Variables are documented in the README.md