dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.
https://helm.irsigler.cloud
GNU General Public License v3.0
151 stars 53 forks source link

introduce service.annotations map #27

Closed marcules closed 2 years ago

marcules commented 2 years ago

Description of the change

This change enables the user of this helm chart to configure additional annotations for the service manifest.

Benefits

Additional annotations on service level can be used by different kubernetes providers to select the type of LoadBalancer that should be provisioned. This is useful if a user wants to only use private load balancers.

Such configurations could be then set through the value-map service.annotations: --set service.annotations.networking\.gke\.io/load-balancer-type="Internal" #gke --set service.annotations.service\.beta\.kubernetes\.io/azure-load-balancer-internal="true" #aks --set service.annotations.service\.beta\.kubernetes\.io/aws-load-balancer-ip-address-type="dualstack" #eks ipv4+ipv6

Possible drawbacks

None that I can think of

Checklist

dirsigler commented 2 years ago

Awesome addition 🤩

marcules commented 2 years ago

@dirsigler I think the release action failed because I used the same minor version for both PRs (didn't know which one you'd pull in first) - sorry for that

dirsigler commented 2 years ago

No worries :D Saw both versions but didn't realize the problem. Already opened a PR by myself to bump the minor version again #29