Closed mahaupt closed 2 years ago
Sound reasonable to me, thanks for the contribution :)
If you change the template for the deployment we also should change it in here charts/uptime-kuma/templates/statefulset.yaml
Thank you very much for your contribution! As @beatkind already said, we should also change it for the StatefulSet to reflect the changes on both. https://github.com/dirsigler/uptime-kuma-helm/blob/main/charts/uptime-kuma/templates/statefulset.yaml#L92-L93
/lgtm
Omitting storageClassName, when omitted in values.yaml. Therefore, the real default storageClass is used. Also removed the volumeModes because it is optional.
Description of the change
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.