Fix using default storageClass

dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.

https://helm.irsigler.cloud

GNU General Public License v3.0

151 stars 53 forks source link

Fix using default storageClass #36

Closed mahaupt closed 2 years ago

mahaupt commented 2 years ago

Omitting storageClassName, when omitted in values.yaml. Therefore, the real default storageClass is used. Also removed the volumeModes because it is optional.

Description of the change

Benefits

Possible drawbacks

Applicable issues

fixes #

Additional information

Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Variables are documented in the README.md

beatkind commented 2 years ago

Sound reasonable to me, thanks for the contribution :)

If you change the template for the deployment we also should change it in here charts/uptime-kuma/templates/statefulset.yaml

dirsigler commented 2 years ago

Thank you very much for your contribution! As @beatkind already said, we should also change it for the StatefulSet to reflect the changes on both. https://github.com/dirsigler/uptime-kuma-helm/blob/main/charts/uptime-kuma/templates/statefulset.yaml#L92-L93

beatkind commented 2 years ago

/lgtm