dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.
https://helm.irsigler.cloud
GNU General Public License v3.0
151 stars 53 forks source link

Fix Default Port issue in Helm Chart #40

Closed idjohnson closed 2 years ago

idjohnson commented 2 years ago

Fix Helm chart - pod crashes with default values - requires a port to be set.

Description of the change

This change sets the default port for the Uptime Kuma container which is, by default, 3001.

Benefits

Fixes crashes when using the helm chart with default values

Possible drawbacks

Uptime Kuma can use a few env vars for options.port. However , I chose UPTIME_KUMA_PORT as the default to use.

Applicable issues

Additional information

Tested locally in K3s on v1.23.3+k3s1 (see freshbrewed.science for blog about Uptime Kuma and how I used)

Checklist

dirsigler commented 2 years ago

Hey @idjohnson

thank you very much for your contribution! I added the change now to my MR #44 .

Therefore I close this one here. Thank you very much <3