search

dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.
https://helm.irsigler.cloud
GNU General Public License v3.0
156 stars 54 forks source link

Add service.nodePort value #72

Closed Scrumplex closed 1 year ago

Scrumplex commented 2 years ago

Description of the change

This change allows the user to define a custom nodePort value for the service generated by this Helm Chart. Setting this value only makes sense if the user set service.type to NodePort.

Benefits

Users that use a load balancer outside the cluster, can define a fixed node-port.

Possible drawbacks

None? :D

Applicable issues

N/A

Additional information

Checklist

Scrumplex commented 1 year ago

Oh, I just found this PR again. Did you forget to review it? :D

dirsigler commented 1 year ago

@Scrumplex it looks like I forgot it, yes.

I am very sorry for this. Life and work is currently quite busy.

Scrumplex commented 1 year ago

@Scrumplex it looks like I forgot it, yes.

I am very sorry for this. Life and work is currently quite busy.

No need to be sorry. Thanks for maintaining this!