dirsigler
commented
1 year ago Hey @CommanderStorm
thanks for the change proposal.
Some little history about the confusing state of the autoscaling and the configuration of a Deployment + Statefulset: There were some changes proposed to the upstream Uptime-Kuma project about adding support for MySQL or Postgres instances as the SQL backend. Furthermore they thought about testing the whole autoscaling scenario and making the application more compatible for that.
As a preparation for these features it was suggested to implement a Statefulset to the Helm Chart and in the future also add some other Charts like the Bitnami MySQL/Postgres to the setup.
As far as I know the whole topic is not finalized or still in discussion, but I agree that having a Statefulset and a Deployment is confusing.
CommanderStorm
Description of the change
This PR removes the autoscaling option from this chart. The reason for it is, that it is unused => does not work
The reason for this is, that uptime-kuma currently does not scale to more than one instance. (local sqlite+ no multi-instance scheduling) I would like to discuss if we should also remove the
replicasoptionBenefits
This removes a non-working/misleading option
Possible drawbacks
In future iterations of uptime kuma, this might be a thing that
Applicable issues
/
Additional information
/
Checklist
Chart.yamlaccording to semver. ^- I would like to discuss on this one what you think this PR qualifies as: since this removes a non-working feature, I would qualify it as a bug-fix => patch increment?