dirsigler / uptime-kuma-helm

This Helm Chart installs Uptime-Kuma from @louislam to your Kubernetes Cluster.
https://helm.irsigler.cloud
GNU General Public License v3.0
147 stars 51 forks source link

Removed the `replicaCount` option #99

Closed CommanderStorm closed 1 year ago

CommanderStorm commented 1 year ago

Description of the change

In #96 we discussed how replicaCount should work and came to the conclusion that this option is likely misleading. This PR removes this option

Benefits

Currently replicaCount would create a duplicate of the app. Depending on if useDeploy is activated, this could have different consequences, but I dont see a way this has usefull sideeffects. Until uptime-kuma supports sharding/..., this should not be a feature this we offer imo

Possible drawbacks

This feature might have to be reverted in the future, if uptime-kuma supports this someday (it is on the backlog, but it is unclear when this wil come to fruition)

Applicable issues

/

Additional information

Checklist

dirsigler commented 1 year ago

Thank you very much and happy Easter holidays! 🐰

CommanderStorm commented 1 year ago

Happy Easter holidays for you too. Thanks for your awesome work ❤️