search

dirty-bits / uni-bites

Uni-Bites is a web-app that compares, contrasts and presents the cafe and deli services on the NUI Galway campus in a format aimed to save students money, while supporting friendly and ethical business practices. It is the result of a 2nd year project in CT216: Software Engineering, taught by Dr. Enda Barrett.
http://danu7.it.nuigalway.ie:8604
MIT License
0 stars 4 forks source link

no arrow functions in clientside linting #56

Open aflaherty13 opened 6 years ago

aflaherty13 commented 6 years ago

Arrow functions are a fairly recent addition to javascript, we should try and avoid them for the client side code as it will not run on older browsers. Essentially any browser only a few versions back, eg a few years old, this would include a lot of existing mobile browsers. This would prevent the user from using the registration and from logging in.

Uncaught SyntaxError: Unexpected token =>
login.js:1 Uncaught SyntaxError: Unexpected token )
aflaherty13 commented 6 years ago

This will require reverting a lot of the clientside linting and removing the arrow functions from the es-lint client config.

dmcfaddengalway commented 6 years ago

I think for right now, we ought to just leave it and work on getting database filling in, we can always go back later for this. But I see the importance of it