search

dirtyfilthy / freshonions-torscraper

Fresh Onions is an open source TOR spider / hidden service onion crawler hosted at zlal32teyptf4tvi.onion
GNU Affero General Public License v3.0
505 stars 148 forks source link

Buggy newlines in certain 404 pages #6

Open Parckwart opened 6 years ago

Parckwart commented 6 years ago

http://zlal32teyptf4tvi.onion/path/foobar

If a search for a path is performed which results in no matches being found, the 404 message has "\n" all over the place.

zaranmd commented 6 years ago

@Parckwart Do you mean that the results of page table are 404 not found?

Parckwart commented 6 years ago

Whoops, I screwed up the link: Fixed link There is a 404 error page, as there should be. But there's a lot of "\n"'s in there red error message.

Screenshot: zlal404

zaranmd commented 6 years ago

@Parckwart i think it should be a temporarily problem... is that so important? I have a question from you, did you run this project successfully?

Parckwart commented 6 years ago

Sure, not an important issue at all. Just something I wanted to note.

I didn't attempt to set up the project (however I might take a look at it in the future). I Just noticed it with your installation.

L3houx commented 6 years ago

Hey @Parckwart , I fixed it! It was in the app.py script. The problem came when it called the error.html page. The ,404 at the end of the lane cause the \n. If you remove it, it will be all good. It had another problem link to that, if you searched something wrong, it will redirect to the error.html page but if you looked the HTTP code, this will be a 302 Found instead of 404 Not Found but the way he coded it, it can need huge modifications to change the 304 to 404. So if you removed , 404 it will work.