search

dis-moi / backend

DisMoi Bakend API - 💬 Stay informed everywhere on the web
https://api.dismoi.io/v4
Other
5 stars 2 forks source link

As contributor, I can add a group of domains (and not only domains) in a group of domains #441

Open MaartenLMEM opened 3 years ago

MaartenLMEM commented 3 years ago

Example : "Habillement et prêt à porter" will contain group of domains "Habillement luxe homme" et "habillement luxe mixte + other domains

Please first size it and we ll see

lutangar commented 3 years ago

I'd say Size S :shirt: as long as we stick to one level of recursion... but there might not be validation everywhere to ensure that's actually the case. We'll only fetch domainSets inside a domainSet and that's it.

This will also generate more matchintContext so might be a performance impact.

This is handle backend side so I'd say there are no impact on any frontend side.

MaartenLMEM commented 3 years ago

From my contributor point of view, this 1st level would be useful. @lutangar Do you see any risk of breaking something, or are you completely confident in and outs of this feature ?

but there might not be validation everywhere to ensure that's actually the case.

Idea : To be sure there is no mistake we will write "2nd" (for 2nd level) in each title of a group of domain that contains other groups.

lutangar commented 3 years ago

Just a warning note on the MatchingContext v4 normalizer wich probably need fixing already... V4 should use $matchingContext->getFullUrlRegex($this->escaper) as in v3

MaartenLMEM commented 3 years ago

Postponed.