dis-moi / backend

DisMoi Bakend API - 💬 Stay informed everywhere on the web
https://api.dismoi.io/v4
Other
5 stars 2 forks source link

feat(matching): introduce product matching engine #455

Closed lutangar closed 3 years ago

lutangar commented 3 years ago

Uses part of the https://schema.org vocabulary. Make use of the api platform schema generator to bootstrap entities.

resolves #448

This still miss a few tests and CS and stan analysis fixes but the concept is already reviewable @JalilArfaoui

Screenshot from 2021-09-22 18-14-38

MaartenLMEM commented 3 years ago

@lutangar we need all fields that are mentionned in the issue. In the scrernshot I do not see those :

Same for other categorie we need what we asked. Otherwise contributors will have to fullfill several time same fields and add comment saying this is ok but only if we exclude this term etc.

JalilArfaoui commented 3 years ago

@lutangar @MaartenLMEM I’m merging this so that we can start filling the field …

JalilArfaoui commented 3 years ago

@MaartenLMEM can you approve this in staging and confirm deployment to production ?

JalilArfaoui commented 2 years ago

Maybe we can have a look at this together @prk-dismoi

MaartenLMEM commented 2 years ago

All right. @JalilArfaoui I am back this week if you have any question. This part won't be used on Le Même en local extension. So from my point of view we can postpone next step design work.

JalilArfaoui commented 2 years ago

@MaartenLMEM this is already merged and in staging...

Either it's good enough to be pushed, either we rollback or amend the changes...

MaartenLMEM commented 2 years ago

ok no problem we can keep it