dis-moi / extension

:speech_balloon: Never browse alone again
https://www.dismoi.io/
Other
42 stars 12 forks source link

On oui.sncf, extension displays link as relative not absolute #1044

Open laurentperez opened 3 years ago

laurentperez commented 3 years ago

Describe the bug Possible duplicate of https://github.com/dis-moi/extension/issues/755 Visit https://www.oui.sncf/ Lookup a destination Extension displays alternative links as relative, not absolute (no http or https link), so links for blablacar, driiveme, etcc. are broken

Example : https://www.oui.sncf/commande/services/www.driiveme.com?utm_medium=Dismoi_extension_navigateur

To Reproduce

Unfortunately, not always reproducible

Steps to reproduce the behavior:

  1. Go to oui.sncf
laurentperez commented 3 years ago

@JalilArfaoui

MaartenLMEM commented 3 years ago

Thank you @laurentperez ! I changed the links on this example. An on others bubbles with relative links. Nevertheless, we will have to add a mechanism to avoid this extension behaviour : writing url without www. is quite common for contributors.

Next step : Add a mechanism that avoid link open url on a wrong way when contributor does not specify http or https in his url. priority : Not a urgent because there are not other cases for now

JalilArfaoui commented 3 years ago

Thanks for pointing that @laurentperez !