search

dis-moi / extension

:speech_balloon: Never browse alone again
https://www.dismoi.io/
Other
42 stars 12 forks source link

feat(contribution): new no notice screen #1136

Closed gregoirelacoste closed 3 years ago

gregoirelacoste commented 3 years ago

closes #1126 For you @newick @lutangar I have a typescript issue, i have to push --no-verify, could check ?

lutangar commented 3 years ago

I'm on it.

lutangar commented 3 years ago

Looks fine on my end and on the CI, probably because your local dependencies are different, since you're working on the website branch at the same time.

About redux-form, for multiple steps form here's the idiomatic way : https://redux-form.com/6.0.0-alpha.6/examples/wizard/

I thought it was your isssue (wrap each component inside a withReduxForm decorator) but apparently it's not so don't pay too much attention to this.

gregoirelacoste commented 3 years ago

@lutangar thx for your feedback

gregoirelacoste commented 3 years ago

@lutangar i have some ts issues from bad node modules dependencies even if i removed the bad yarn.lock and replace by the one from master, could you help me please ?

bmenant commented 3 years ago

:tada: This PR is included in version 3.88.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: