search

dis-moi / extension

:speech_balloon: Never browse alone again
https://www.dismoi.io/
Other
42 stars 11 forks source link

Proding profiles page of LMEL is the same as Dismoi #1178

Closed MaartenLMEM closed 2 years ago

MaartenLMEM commented 2 years ago

Problem : https://proding-profiles.dismoi.io/eclaireurs : contributors page adress is the same for LMEL as for Dismoi. Therefore, the list of contributors is the same, while it should be a restricted list of local ones.

To reproduce :

  1. Install LMEM proding (or staging)
  2. onboarding opens
  3. choose contributors and validate
  4. it open list of contributor page : https://proding-profiles.dismoi.io/eclaireurs?pk_campaign=installed-contributors-list
JalilArfaoui commented 2 years ago

:tada: This issue has been resolved in version 3.93.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

prk-dismoi commented 2 years ago

An additional issue which might warrant its own ticket. From abroad, my browser opens: https://lememe.fr/en/guides/?pk_campaign=installed upon installation of the latest Firefox proding extension (3.93.5) @jalil, pls let me know if you prefer I open a separate ticket for this non-FR issue.

JalilArfaoui commented 2 years ago

Yes, please @prk-dismoi so that we can keep track of what needs to be done

prk-dismoi commented 2 years ago

Yes, please @prk-dismoi so that we can keep track of what needs to be done

Thanks. Created an investigation ticket here: https://github.com/dis-moi/extension/issues/1189 Once its clear what we do with EN I'll review the flows and write up precise tasks accordingly (if needed).