search

dis-moi / extension

:speech_balloon: Never browse alone again
https://www.dismoi.io/
Other
42 stars 12 forks source link

Consider using Sass #13

Closed DavidBruant closed 8 years ago

DavidBruant commented 8 years ago

Or Scss to be accurate http://sass-lang.com/

bmenant commented 8 years ago

Good call.

Actually, those huge, ugly and unbearable CSS files are built with SASS. Sources are available in the original prototype https://github.com/insitu-project/browser-addons-commons/tree/master/app/styles

As a matter of fact, when it comes to integrate styles to this new architecture, @lilobase and I agreed on making a first quick & dirty copy/paste from the former sources.

Now, it’s time to write and build styles in a way better proper manner.

Back in the days, my opinion was that this question is interlocked with the composability of the UI as a whole (https://github.com/insitu-project/proto-ext/issues/8). In other words, we do have to split that big react component into smaller components. Some of those components could (or should) have their own pieces of style. @lilobase then wondered if PostCSS could come in a handy here. The question is yet to be answered.