Open christpet opened 3 years ago
@lutangar I suggest to create a new field on contribution: language and get the language by the api. Then i could display the appropriate language by user pref language or url. It sounds good for you ? cc @christpet
I suggest a Quick Win for this issue by doing the following actions:
@lutangar @JalilArfaoui @MaartenLMEM are you ok with that ?
From UX side for contributors and users, looks good.
a good practice would be to add le lang
HTML attribute to the contributions markup ;)
Maybe It could help to sort?
For the backend part there is a dedicated card https://github.com/dis-moi/backend/issues/343 to discuss the implementation details. We probably should start there and the implementation of the extension will follow. There are still product related questions open for debates there!
I just answered to the ramaining question here dis-moi/backend#343 . BO issue is here : https://github.com/dis-moi/backend/issues/380
we can start this issue after the validation of https://github.com/dis-moi/backend/pull/384
@gregoirelacoste Pierrick tested from Germany and English profiles did not show up as first on https://proding-profiles.dismoi.io/eclaireurs/ If I but my broswer language in English : same there is no language based order
Please can you alos remind me what is the order based on ? Country or browser language ?
@MaartenLMEM are speacking about profile page ? because it's not based on browser config but on URL. Could you try with /en/guides url plz
@gregoirelacoste c'est bon mais... sous les contributeurs anglais , les contributeurs frnaçais sont affihés en ordre croissant alors que ça devrait commencer par le plus populaire (Le Même en Mieux). Capture faite sous chrome :
je fais une issue dédiée, celle ci est validée
même problème que : #1095 ce sera réglé avec #1096
** User stories: