Primarily show contributions categorized in the appropriate language (English Version)

dis-moi / extension

:speech_balloon: Never browse alone again

https://www.dismoi.io/

Other

42 stars 12 forks source link

Primarily show contributions categorized in the appropriate language (English Version) #794

Open christpet opened 3 years ago

christpet commented 3 years ago

** User stories:

If I am an English-speaking user, I should primarily see contributions and sources that are categorized as English-speaking

gregoirelacoste commented 3 years ago

@lutangar I suggest to create a new field on contribution: language and get the language by the api. Then i could display the appropriate language by user pref language or url. It sounds good for you ? cc @christpet

gregoirelacoste commented 3 years ago

I suggest a Quick Win for this issue by doing the following actions:

In Backend

create a new LANG field in DB for contributions enum : FR | EN (default FR)
add the Lang field in the contributions API

In Backoffice

create EN and FR radio button on contributions:
checked by default in FR

In Front

Store

in fetchNotices saga, add a getMyLanguageInFirst () function. It returns an array of sorted notices (user language first, the others after). Language detection comes from the browser config get by i18next

In Extension and Profile

we map the notices with its language first (we display the others anyway)

@lutangar @JalilArfaoui @MaartenLMEM are you ok with that ?

MaartenLMEM commented 3 years ago

From UX side for contributors and users, looks good.

newick commented 3 years ago

a good practice would be to add le lang HTML attribute to the contributions markup ;)

Maybe It could help to sort?

lutangar commented 3 years ago

For the backend part there is a dedicated card https://github.com/dis-moi/backend/issues/343 to discuss the implementation details. We probably should start there and the implementation of the extension will follow. There are still product related questions open for debates there!

MaartenLMEM commented 3 years ago

I just answered to the ramaining question here dis-moi/backend#343 . BO issue is here : https://github.com/dis-moi/backend/issues/380

gregoirelacoste commented 3 years ago

we can start this issue after the validation of https://github.com/dis-moi/backend/pull/384

MaartenLMEM commented 3 years ago

@gregoirelacoste Pierrick tested from Germany and English profiles did not show up as first on https://proding-profiles.dismoi.io/eclaireurs/ If I but my broswer language in English : same there is no language based order

Please can you alos remind me what is the order based on ? Country or browser language ?

gregoirelacoste commented 3 years ago

@MaartenLMEM are speacking about profile page ? because it's not based on browser config but on URL. Could you try with /en/guides url plz

MaartenLMEM commented 3 years ago

@gregoirelacoste c'est bon mais... sous les contributeurs anglais , les contributeurs frnaçais sont affihés en ordre croissant alors que ça devrait commencer par le plus populaire (Le Même en Mieux). Capture faite sous chrome :

MaartenLMEM commented 3 years ago

je fais une issue dédiée, celle ci est validée

gregoirelacoste commented 3 years ago

même problème que : #1095 ce sera réglé avec #1096