dis-moi / extension

:speech_balloon: Never browse alone again
https://www.dismoi.io/
Other
42 stars 12 forks source link

Logs are polluting in the console in webdev tools when Extension is installed #878

Open tobika opened 3 years ago

tobika commented 3 years ago

Describe the bug I have installed the dis-moi extension on Firefox. When I'm browsing/working and I open the webdev tools I can see logs from Logger.ts. Is this intentional? Not sure an extension should log here if developers try to concentrate on their own work/logs.

[INFO] Content script injected... Logger.ts:30:43
[INFO] Running content script ... Logger.ts:30:43
[INFO] Listening messages ... Logger.ts:30:43

To Reproduce Steps to reproduce the behavior:

  1. Go to any page on the web
  2. Open the webdev tools and read the console

Expected behavior I don't expect to see logs from the extension in my console (Maybe only severe errors?)

Screenshots Screenshot from 2021-03-26 16-03-55

Desktop (please complete the following information):

Extension

christpet commented 3 years ago

Thanks for flagging this and creating the issue, @tobika ! We'll look into how we could solve this. Would hate to have the devs out there disabling DisMoi every time you need to look at console logs.

For this I will ping our logging expert @JalilArfaoui - what do you think it would take to disable these logs?

bmenant commented 3 years ago

:tada: This issue has been resolved in version 3.71.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

JalilArfaoui commented 2 years ago

Seems that it's (still) logging (again) in production …