search

disarm-dev / douma-api

DiSARM api (2018 and beyond)
MIT License
2 stars 1 forks source link

expose content length header #10

Closed Nicolaidavies closed 6 years ago

Nicolaidavies commented 6 years ago

Could @mosaic141688 please review this.

The default behaviour is not to expose any custom headers, so this should not break anything.

I didn't test with actual data. But the test response to the root route now has a content length header, it didn't before.

onlyjsmith commented 6 years ago

@Nicolaidavies can you test with real data?

Nicolaidavies commented 6 years ago

@onlyjsmith yes

onlyjsmith commented 6 years ago

If that's causing problems because it's hard to get a dev server started, can you add/update a card that describes probs we have seeding a dev server?

Nicolaidavies commented 6 years ago

Yeah, it's taking too long because of seed data. Will create card.

With this particular card I feel confident that merging it without testing is alright and won't cause any problems. Any other major changes should of course always be tested.

Nicolaidavies commented 6 years ago

discussed with @onlyjsmith - will merge and redeploy