Closed mosaic141688 closed 6 years ago
Why are we getting these different options coming in from the client? Any way we can simplify it on the client?
cc @Nicolaidavies
Ah - is it the difference between create
and update
? We're using the same endpoint for both?
yes both create and update use the POST
method
@mosaic141688 looks like you've taken out the _id
from the tests. Are we testing both branches of the if
?
No netlify link for me to review let me know when to test anyway!
I have removed the _id
from responses seed data because in actual use the responses are inserted without _id
from the client
@TNgidi the PR does not have a netlify link because its on the API repository, I'm not sure if there is an equivalent way we can use to test the API.
@mosaic141688 that makes sense about the _id
thanks.
@mosaic141688 there's a failing test...
On 392-location_selection-is-removed-when-adding-seasons
I added instance: { slug: 'example_slug' }
to mock store to fix the failing tests. They were failing because the seasons component was accessing the instance.slug
which was not in store in the test mock
Think this PR is old - can close once we're sure #44 includes all the changes we want.
If the body does not have a
config_data
field, the body is used instead as config data to avoid trying to getconfig_id
fromconfig_data
if it is undefined.