search

disarm-dev / douma-app

DiSARM app (2018 and beyond)
MIT License
3 stars 1 forks source link

location_selection is removed when adding season start date #392

Closed Nicolaidavies closed 6 years ago

onlyjsmith commented 6 years ago

Suggest we:

  1. fix the existing 4 configs so they have location_selection: BWA and NAM on both production and staging.
  2. simplify client, so it’s sending a valid season_start_dates array to the /seasons endpoint, along with config_id
  3. change server, so it is responsible for updating the season_start_dates on the correct config object in server.
  4. will need to make sure the client refreshes/re-gets config after the server returns
onlyjsmith commented 6 years ago

Have started branch for 392 to change client. @mosaic141688 is looking at the server.

Nicolaidavies commented 6 years ago

Great, would much prefer that approach!

Nicolaidavies commented 6 years ago

Branches exist for both douma-app and douma-api. Need to merge, probably test before.

onlyjsmith commented 6 years ago

Still to add:

  1. Dialog when starting seasons editor: "Editing seasons dates requires reloading the application - Continue/Go back"
  2. After saving/deleting, execute location.reload or equiv to force new config to load.
onlyjsmith commented 6 years ago

@mosaic141688 has added 1 & 2 above.