disarm-dev / douma-app

DiSARM app (2018 and beyond)
MIT License
3 stars 1 forks source link

[add rule] irs_record_point.metadata.optional_fields can only include 'team_name' #437

Open onlyjsmith opened 6 years ago

onlyjsmith commented 6 years ago

@onlyjsmith commented on Tue Jul 03 2018

Looks like we can only store team_name in the store, so this would break if we added a new property into the config.

Code below from douma-app, irs_record_point

template image

computed image

methods image


@onlyjsmith commented on Tue Jul 03 2018

If you can see a way we're not opening ourselves to having more than one optional field, then we don't need this rule!

onlyjsmith commented 6 years ago

Fix on douma-app,

Nicolaidavies commented 6 years ago

Have made required changes. Need to test once #438 has been fixed.

onlyjsmith commented 6 years ago

@Nicolaidavies can i make a PR for this now?

onlyjsmith commented 6 years ago

Or, even better - can you?!