disarm-dev / douma-app

DiSARM app (2018 and beyond)
MIT License
3 stars 1 forks source link

[ext] Add form information to Namibia response points on dashboard map #456

Closed TNgidi closed 5 years ago

TNgidi commented 5 years ago

@onlyjsmith commented on Mon Jul 16 2018

External feedback source: https://github.com/disarm-platform/user-requests-and-feedback/issues/85 When user clicks on a response point they should be able to see the following information:

  1. Date form was recorded
  2. Village name
  3. Head of household name
  4. Household health number

@onlyjsmith commented on Thu Jul 19 2018

@TNgidi can you try to figure out exactly what are the field names for each of these from the form?

TNgidi commented 5 years ago
  1. Date form was recorded -
  2. Village name -
  3. Head of household name - name_household
  4. Household health number - health_number

@onlyjsmith I do not know where to find the first two fields

onlyjsmith commented 5 years ago

That’s great - we can find the other two together.

Nicolaidavies commented 5 years ago
  1. Date - field is recorded_on but it needs some formatting before we display it.
  2. Village name - field is location.selection.name

Will need to add all the fields to:

applets.irs_monitor.map.response_point_fields

Nicolaidavies commented 5 years ago

Deployed to stage.

onlyjsmith commented 5 years ago

Does this require any code? Just checking you mean "config updated on stage"?

TNgidi commented 5 years ago

@Nicolaidavies Is it possible to make the village information not pop when a response point is clicked? DiSARM Namibia IRS Tool 2018-07-26 09-00-18.png

Nicolaidavies commented 5 years ago

@onlyjsmith No code, just config.

Nicolaidavies commented 5 years ago

@TNgidi Not really. You can hide the village layer by selecting "show areas by: No layer". Then you don't have two popups.

The problem is when showing both the villages and responses, we cannot tell which layer you're interested in. So we show both popups.

onlyjsmith commented 5 years ago

I can’t remember exactly how we implemented (and I vaguely recall trying this before), but there’s definitely an order in which the layers are rendered, so we should be able to tell which layer is on top?

onlyjsmith commented 5 years ago

Think problem is we have two independent handlers: _responses_click_handler and a regular _click_handler. They both fire. We should combine their functionality.

So let’s not do this now! @tngidi can you add a new issue for this ‘duplicate pop-up on click’ issue? (Might be worth searching existing issues in douma and _tickets first)

TNgidi commented 5 years ago

Ok, @onlyjsmith should this issue be here in the douma-app board or tickets

onlyjsmith commented 5 years ago

Can be in _tickets - thanks.

TNgidi commented 5 years ago

Done