search

disarm-dev / douma-app

DiSARM app (2018 and beyond)
MIT License
3 stars 1 forks source link

[ext] Namibia dashboard summary table - separate % Refused and % Locked columns by first visit vs. mop-up #461

Closed TNgidi closed 5 years ago

TNgidi commented 5 years ago

@onlyjsmith commented on Thu Jul 19 2018

External feedback source: https://github.com/disarm-platform/user-requests-and-feedback/issues/87 Currently we have the following 2 columns on the far right of the dashboard:

% Refused (# structures unsprayed where Reason == Refused) and % Locked (# structures sprayed where Reason == Locked)

We want to split this into:

% Refused First Visit (# structures unsprayed (first visit) where Reason == Refused) % Refused Mop-up (# structures unsprayed (mop-up) where Reason == Refused) % Locked First Visit (# structures sprayed (first visit) where Reason == Locked) % Locked Mop-up (# structures sprayed (mop-up) where Reason == Locked)

This is dependent on #86 where there will be separate questions for number unsprayed first visit vs. number unsprayed mop-up

Nicolaidavies commented 5 years ago

Need to create new aggregations. Not really problematic.

The changes to the form will be a bit challenging. See #458.

Nicolaidavies commented 5 years ago

@TNgidi I updated the aggregations and the new config is live on stage as version 1.0.15.

TNgidi commented 5 years ago

Thanks for the information @Nicolaidavies, I will test now

TNgidi commented 5 years ago

I don't know if the coverage calculations are correct. is the screen show below I think we should show atleast 0.0.... something because there structures sprayed calculations

TNgidi commented 5 years ago

calculations

Nicolaidavies commented 5 years ago

Strange, I haven't touched anything with the coverage. The refused and locked will show up as 0 until we create new fake_forms.

Nicolaidavies commented 5 years ago

@TNgidi Please take a look at the instance tarajuke-287 it has coverage showing up correctly.

TNgidi commented 5 years ago

@Nicolaidavies On this instance “testingcoverage” I have added some records with structures that match the columns on the table (locked first visit, locked mop up, refused first visit, refused mop up) but the table still shows 0 %

onlyjsmith commented 5 years ago

Please check Sameen's update on https://github.com/disarm-platform/user-requests-and-feedback/issues/87

TNgidi commented 5 years ago

@Nicolaidavies is OK to add records for more testing to your instance ID tarajuke-287 ?

Nicolaidavies commented 5 years ago

This change was deployed to staging and production.

Confirmed working by Sameen. Moving to 'Review/QA'

TNgidi commented 5 years ago

Done