search

disarm-platform / fn-covariate-extractor

OpenFaas version of the covariate extractor
MIT License
1 stars 0 forks source link

Need a reliable way to describe list of packages required #2

Open onlyjsmith opened 5 years ago

onlyjsmith commented 5 years ago

@onlyjsmith commented on Tue Dec 11 2018

This is something R should be able to do, but I'm not certain how.

Maybe through configuring it as a package? There's also Packrat.

The desired outcome is: we have a simple way to recreate the list of packages required, without needing to go through every file to check for library(...) statements.

onlyjsmith commented 4 years ago

We've added the install_packages.R script - seems to do (some of) this job. The part it doesn't do is making sure that the correct versions of packages are installed. Maybe there is a way to set that when you install a package?

HughSt commented 4 years ago

Yes I think this is possible

https://support.rstudio.com/hc/en-us/articles/219949047-Installing-older-versions-of-packages

But isn't this exactly what containerizing avoids? Or are we worried about situations where others build their own containers from our code?

onlyjsmith commented 4 years ago

Not exactly. The problem would be that install.packages will usually go get the most recent version of the package, and that version could change over time, potentially introducing backwards-incompatible changes: we won't have completely reproducible builds. It would be the same for us or someone else building the image in the future.

I'd leave in icebox though. Let's wait till we hit this as a recurrent problem before fixing though, at the moment it's just a potential problem.

HughSt commented 4 years ago

Agreed