Closed sbabur closed 6 years ago
@TNgidi @Nicolaidavies I'm getting a 502 server error on survey js so I tried updating it in Notepad++ directly D:
Are you two having any luck with surveyjs?
Hopefully syntax error-free form attached. You can see that "n_rooms_material' is no longer an integer input as a refusal category, we now have a field called 'unsprayable' to capture the number of unsprayable rooms on the same page we capture total sprayable/modern sprayable/traditional sprayable room counts. The single dashboard summary table column for number of unsprayable rooms should just aggregate this field.
Thanks for the form @sbabur it all works well, but I do not understand what you mean when you say "You can see that "n_rooms_material' is no longer an integer input as a refusal category". I tried to find the field "n_rooms_material" to understand more about it but I did not find it, did you completely remove it?
Yes I completely removed that field. Instead of specifying at the end how many rooms were not sprayed due to being unsprayable, i removed that and added a separate new question in the page where we collect household room information.
Sent from my Verizon, Samsung Galaxy smartphone
-------- Original message -------- From: Thokozani Ngidi notifications@github.com Date: 9/5/18 9:32 AM (GMT+02:00) To: disarm-platform/user-requests-and-feedback user-requests-and-feedback@noreply.github.com Cc: Sameen Babur sbabur@clintonhealthaccess.org, Mention mention@noreply.github.com Subject: Re: [disarm-platform/user-requests-and-feedback] Update Botswana Form (#99)
Thanks for the form @sbaburhttps://github.com/sbabur it all works well, but I do not understand what you mean when you say "You can see that "n_rooms_material' is no longer an integer input as a refusal category". I tried to find the field "n_rooms_material" to understand more about it but I did not find it, did you completely remove it?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/disarm-platform/user-requests-and-feedback/issues/99#issuecomment-418628905, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AkH1D_jWQnBRa2Tf1QG-5VeKRwS24PkQks5uX33ugaJpZM4WXAq0.
Okay, I understand now. We will work on it and let you know to test
@TNgidi Thanks Thokozani. Can you let me know when you are aiming to have these 3 changes ready for me test? Would by end of week be possible?
@sbabur It should be ready after lunch. @Nicolaidavies will be working on it around noon
@sbabur Please try again with surveyjs editor on your side, we have uncovered errors on the form you sent.
See attached
@sbabur Thanks
@sbabur The form has been updated on config version 1.0.25 on staging.
@Nicolaidavies Looks good, validated, will just wait for #101 to be resolved
@Nicolaidavies Hi Nicolai, apologies but I missed one skip logic in the form according to the country team! (do not need to ask about unsprayed rooms during mop-ups). Can you update the form with the attached?
@sbabur no problem. I updated staging to version 1.0.26.
@Nicolaidavies ugh last one....had a typo
@sbabur It's been updated, still on version 1.0.26.
Can I ask you to get the json as "Valid json" from surveyJS editor? It saves me an extra step.
@Nicolaidavies yes of course, completely forgot about that step. Everything looks good, can move to prod.
@sbabur Now on production with version 1.0.26.
Validated, can close
@onlyjsmith @TNgidi @Nicolaidavies I can make the form changes - can you add the existing json here?
Summary of changes: