Backup database based on container label instead of image name?

[pwFoo]

Instead of backup container databases basend on image name add an optional label to add a database to the backup?

There are some database images without the database name like "mysql" in the image name. WOuld be nice to add by label rancher-backup=mysql or something else.

[disaster37]

Ok, is a good idea, I will try to enhance with that. First, check label, then check image name

[fredleger]

+1 seems like a good idea. Maybe both and configurable ?

[disaster37]

You can now use label backup.type to discover service to be backuped. First, it search on backup.type label, then it search on image name.

[grabekm90]

The tool should at the beginning look for a container with a label backup.type set, i.e. backup.type=mongo, right? I asking because it does not work as described and the tool tries to backup each of my mongo instances from a shared cluster instead of only from the mongos router with backup.type=mongo label.

[fredleger]

I think this is expected : 1) backup all databases with backup.type=mongo 2) backup all databases with mongo in the container name (might be a regexp more precise than that)

So does your container name contains mongo in the name ?

Le jeu. 7 févr. 2019 à 03:09, grabekm90 notifications@github.com a écrit :

The tool should at the beginning look for a container with a label backup.type set, i.e. backup.type=mongo, right? I asking because it does not work as described and the tool tries to backup each of my mongo instances from a shared cluster instead of only from the mongos router with backup.type=mongo label.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/disaster37/rancher-backup/issues/16#issuecomment-461263453, or mute the thread https://github.com/notifications/unsubscribe-auth/ACpmdejNC4dWCFCxzuILpZNWKEPE28xFks5vK4rmgaJpZM4OYMMS .

-- [image: webofmars | build-and-run] Frederic Leger fondateur | webofmars co-fondateur | build-and-run.fr M: 06.52.77.53.54 webofmars.com [image: linkedin] https://www.linkedin.com/company/webofmars/ [image: twitter] https://twitter.com/webofmars [image: youtube] https://www.youtube.com/channel/UCi77lDIsszaryN0flTS9EOw [image: github] https://github.com/webofmars [image: link] https://www.build-and-run.fr/

P.S. During business hours, focus is my work philosophy. So to fully serve my customers, I do not consult emails during the day. Please send me an SMS if anything urgent otherwise my reply might take a few workdays.

[grabekm90]

From README:

First it search on label called backup.type and if doesn't found, it search on image name.

Right, my containers name contains mongo, but it is strange that the name implies backup. May backup.type=none should be introduced to omit these containers and be backward compatible.