search

disc-in / UltimateApp

Developing a mobile app to enhance Ultimate coaching abilities
https://www.facebook.com/DiscInApp/
MIT License
26 stars 9 forks source link

Fix VimeoVideo.js with updated Vimeo API #411

Open JCapul opened 2 months ago

JCapul commented 2 months ago

This is a quick and dirty attempt to implement the changes I could figured out from the revamped Vimeo API documentation (ref: https://developer.vimeo.com/api/files/video-links)

I am complete noob in mobile dev so I would need to spare some time to setup and understand the dev environment required to properly test and validate this change. So I just thought, it might be quicker to just push this PR, initiate the discussion, and maybe you will be able to check it much quicker than myself.

Before sending your pull-request 💌 make sure :

JCapul commented 2 months ago

attempt to fix #407

JCapul commented 2 months ago

Ok, at least I managed to run the tests and they all pass. Now, I just need to check if the fix actually work...sorry that's not really the proper way to do all this !

JCapul commented 2 months ago

Ok, I finally managed to make Expo Go work and start digging into the problem. It looks like Vimeo now requires to have the app registered and to use an access token for the request. With the changes I have made to reflect the new API spec, I get an error 401 Unauthorized.

Edit: confirmed by https://stackoverflow.com/a/74120966