Possible ES6-related improvements

discipl / core

Discipl Core

GNU General Public License v3.0

9 stars 8 forks source link

Possible ES6-related improvements #11

Closed pimotte closed 5 years ago

pimotte commented 5 years ago

Two small proposals:

Replace the commonJS export with an ES6 export.
Replace the require with a dynamic import

Both would modernize the code. The dynamic import is not natively supported in firefox and IE (is supported by Chrome/Safari/Edge/NodeJS), but is supported by Babel, so as I see it this shouldn't cause any problems.

bkaptijn commented 5 years ago

I agree.

pimotte commented 5 years ago

Some initial investigation:

es6 modules do have native support in node, but it is experimental (both in 10.x and 11.x)
Using es6 modules with any of the test frameworks (mocha, jasmine) would require using babel, since these don't have native es6 support yet.

bkaptijn commented 5 years ago

true, never ran into problems with nodejs yet though. The API (and most connectors) need to be able to run (and thus tested) both in nodejs, in browsers and react native (even expo.io) so we'd need or be using babel / browserify (or webpack) already.

pimotte commented 5 years ago

Closed with #13