WIP: ES6 and testing framework

discipl / core

Discipl Core

GNU General Public License v3.0

9 stars 8 forks source link

WIP: ES6 and testing framework #13

Closed pimotte closed 5 years ago

pimotte commented 5 years ago

I tried out the first part of #11, which immediately implied that the tests would break (rewire does not support es6 modules), so I also started on the test framework #12

I'm actually not too sure about whether we want to use karma for testing at library level, nor if we want to be doing webpack at library level. Input here is appreciated.

This PR does some initial setup for using mocha, but is not finished.

TODO:

[x] Use dynamic import instead of require
[ ] Reimplement all tests in mocha

pimotte commented 5 years ago

@bkaptijn This wasn't actually finished yet, so there are a lot fewer tests now :sweat_smile:

bkaptijn commented 5 years ago

I know ;-P, but the old ones arent that great (atomic for instance). Just look at the old ones and reimplement the tests. I'm going to do the same for discipl-core-memory etc.. will wait on you saying you are finished before merging from now on.