discipl / core

Discipl Core

GNU General Public License v3.0

9 stars 8 forks source link

Adding code coverage #17

Closed pimotte closed 5 years ago

pimotte commented 5 years ago

Based on #16

Does actually not include karma, because it I couldn't get it to work, and if we can get coverage without it, I'm not sure why we would need it.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a19e428). Click here to learn what that means. The diff coverage is 97.64%.

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   95.98%           
=========================================
  Files             ?        2           
  Lines             ?      299           
  Branches          ?        0           
=========================================
  Hits              ?      287           
  Misses            ?       12           
  Partials          ?        0

Impacted Files	Coverage Δ
src/index.spec.js	`100% <100%> (ø)`
src/index.js	`90.97% <89.13%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a19e428...c142021. Read the comment docs.

pimotte commented 5 years ago

Also including codecov may be overkill, as sonar can also track code coverage. This does give allow showing codecoverage before merging.

Edit: Looks like sonar can analyze PRs, but only internal ones: https://docs.travis-ci.com/user/sonarcloud/#analysis-of-internal-pull-requests

bkaptijn commented 5 years ago

If we can use for code coverage even before merge than better use that than yet another tool like karma.

I invitef you to be member of discipl dev github team earlier this week .. are you not able to create your own dev branch? should be possible for you to make internal PR's

bkaptijn commented 5 years ago

But let us try using codecov for now too

pimotte commented 5 years ago

If we can use for code coverage even before merge than better use that than yet another tool like karma.

I invitef you to be member of discipl dev github team earlier this week .. are you not able to create your own dev branch? should be possible for you to make internal PR's

@bkaptijn Nope. My guess is that you would want to add the repository here https://github.com/orgs/discipl/teams/discipl-dev/repositories with "write" rights, or add the team here https://github.com/discipl/core/settings/collaboration

bkaptijn commented 5 years ago

Ah ok, sorry, added repos with write access to the team but i now see steven used the team for non devs too.. will create a better team structure later today