search

discipl / core

Discipl Core
GNU General Public License v3.0
9 stars 8 forks source link

fix issue #15, infinite recursion at verifying attestation of a revok… #20

Closed bkaptijn closed 5 years ago

bkaptijn commented 5 years ago

The implementation of verify() already checks for revocations of revocations and so on in the first (recursive) call to verify(). And as intended, yes it additionally checks for revocation of the original claim too through a second recursive call. The latter should not be done however when the verify method was called to check for revocations as that results in a infinite loop as you encountered.

Changes in this PR fixes this. Added an extra test to test the case of verifying attestation of a revoked claim. Had to change the last test with the mocks too, but that test probably needs some work to test a littlebit more.

codecov-io commented 5 years ago

Codecov Report

Merging #20 into master will increase coverage by 0.72%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   91.24%   91.97%   +0.72%     
==========================================
  Files           2        2              
  Lines         137      137              
==========================================
+ Hits          125      126       +1     
+ Misses         12       11       -1
Impacted Files Coverage Δ
src/index.js 91.72% <100%> (+0.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f178cbe...f29e5cb. Read the comment docs.