discipl / core

Discipl Core
GNU General Public License v3.0
9 stars 8 forks source link

Introducing @discipl/core-baseconnector as dependency #42

Closed pimotte closed 5 years ago

pimotte commented 5 years ago

We explicitly use the baseconnector through BaseConnector.ALLOW, however the dependency was not added. This had not shown up before because all environments had the right dependency indirectly through a connector.

codecov-io commented 5 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files           3        3           
  Lines         164      164           
=======================================
  Hits          162      162           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c58db72...99b8f90. Read the comment docs.