Should "200 OK" replies ever be considered errors?

discogs / discogs_client

DEPRECATED - Official Python Client for the Discogs API

http://www.discogs.com/developers

Other

479 stars 132 forks source link

Should "200 OK" replies ever be considered errors? #27

Closed marado closed 4 years ago

marado commented 10 years ago

See the comment: https://github.com/discogs/discogs_client/commit/f77e060ba3aa32907dcf87520c5006e10cb5b75e#commitcomment-6280087

Basically, we're assuming that if a response has no content an exception should be raised, even if the response http_code is an 200 OK. I'm not saying this is actually a bug, just that it might be... the API documentation isn't explicit about this.

rodneykeeling commented 10 years ago

Generally, yes. Hopefully a 204 No Content would be returned if there is no content. Do you have an example of where a 200 is being returned with no content?

marado commented 10 years ago

This was the script triggering it, I don't know with witch parameter... https://github.com/marado/discogs-compilation-info/blob/master/discogs-compilation-info.py

vreon commented 4 years ago

Hi, thank you for opening this issue.

Unfortunately, this project is no longer actively maintained, and today, we're archiving the repository and publishing the final version to PyPI.

We sincerely appreciate your contribution and regret that we weren't able to give it the attention it deserved.