Checkout fails on Windows due to invalid file names

[zoomorph]

Git checkout of repository fails.... error: unable to create file discogs_client/tests/res/artists/1/releases?per_page=50&page=1.json (Invalid argument) error: unable to create file discogs_client/tests/res/artists/1/releases?per_page=50&page=2.json (Invalid argument) error: unable to create file discogs_client/tests/res/database/search?q=trash80&per_page=50&page=1.json (Invalid argument) error: unable to create file discogs_client/tests/res/masters/4242/versions?per_page=50&page=1.json (Invalid argument) error: unable to create file discogs_client/tests/res/users/example/wants?per_page=50&page=1.json (Invalid argument)

[rodneykeeling]

Hello,

Can you post the command you used to checkout the repo?

Thanks, Rodney

[cburmeister]

Windows probably doesn't like the filenames

[zoomorph]

"git clone https://github.com/discogs/discogs_client.git"

And yea, it's because there are '?'s in those files names, which isn't allowed in Windows.

[doomb0t]

Here is the list of invalid file name characters: \ / ? : * " > < | A workaround may be to install cygwin and checkout the repository into the cygwin filetree

[leo-dor]

Another workaround is to make FilesystemFetcher replace '?' with '_' in the URL, and change existing filenames accordingly. Update: Tried that and the tests still fail on Windows due to symlinks. Any ideas?

[doomb0t]

I was thinking about this recently and realized after seeing that those files are sym links that the checkout would have to be done using cygwin. I have not tried this yet because I am taking a discrete math class, a calculus class, and a machine architecture class right now so time is precious. After June 10th though I would like to start looking into making a portable branch.... not sure if it will get done but I shall try.

[leo-dor]

I've added logic to resolve parameter lists to existing files, see pull request above. It clones OK now. Best of luck with your studies!

[leo-dor]

This is now fixed, can you close the issue?