search

discogs / discogs_client

DEPRECATED - Official Python Client for the Discogs API
http://www.discogs.com/developers
Other
480 stars 132 forks source link

discogs_client doesnt honor Discogs rate limits #82

Closed T-101 closed 4 years ago

T-101 commented 7 years ago

Discogs has recently lowered their rate limit from 240 reqs/min to 60 reqs/min. This obviously means that some applications will hit the limit quite soon.

RobSis commented 7 years ago

I second this. Looking at the code, it seems that the client doesn't honour the limits at all...

It would be great to have limiter based on X-Discogs-Ratelimit headers...

madCode commented 7 years ago

I can't find a place in the code that even returns the ratelimit headers. Hopefully I'm just not looking in the right place. But if they really aren't accessible from the python library, that renders the library almost useless.

RobSis commented 7 years ago

Well, that's too harsh ;) I find the library very useful, although not finished. I'm currently working on the rate-limiting, but I'm still not sure what should the best strategy be.

The bigger problem seems to be inactivity of its developers, but I hope that's just temporary ;)

doomb0t commented 6 years ago

This may not be prioritized because it is documented what the limits values are so your application layer can account for this (ie take a timestamp at time of first request and make sure for the next minute the limit isn't reached) and, while it would not be the hardest change to make it would involve altering some of the wrapper behavior, which may require a fair amount of work to avoid issues with the tests etc. Because of this the developers may not see this as a bug report but a feature request, and it seems that new features aren't a priority for the client.

alifhughes commented 4 years ago

Any chance of this being looked into again? I understand @doomb0t 's point completely, that it is implied we are expected to manage this, but it would be good to know for certain. Especially as there are 3 PRs open that could fix this and close issue 92 as well as this one. If it isn't, I guess are we expected to fork and include changes in our forks?

alifhughes commented 4 years ago

@brephophagist bump. Seems I am not the only one requesting it. Two recent threads started in the discogs api forum asking for the same thing. Here and here.

JOJ0 commented 4 years ago

Thanks for mentioning it here @alifhughes. Little update on this one: https://www.discogs.com/forum/thread/818998

vreon commented 4 years ago

Hi, thank you for opening this issue.

Unfortunately, this project is no longer actively maintained, and today, we're archiving the repository and publishing the final version to PyPI.

We sincerely appreciate your contribution and regret that we weren't able to give it the attention it deserved.