search

discogs / discogs_client

DEPRECATED - Official Python Client for the Discogs API
http://www.discogs.com/developers
Other
480 stars 132 forks source link

Adjust name to reflect oauth version #87

Closed akonkol closed 4 years ago

akonkol commented 6 years ago

I was looking to integrate one of my applications with discogs's api. Upon reviewing the client code I saw 'Oauth2Fetcher' and assumed that oauth 2.0 was being used. After reading a summary of the spec I believe that this client is using oauth 1.0a due to it's use of oauth_verifier.

In addition, Oauth 1.0a is mentioned in the code comments:

class OAuth2Fetcher(Fetcher):
        """Fetches via HTTP + OAuth 1.0a from the Discogs API."""
        def __init__(self, consumer_key, consumer_secret, token=None, secret=None):
            self.client = oauth1.Client(consumer_key, client_secret=consumer_secret)
            self.store_token(token, secret)
coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.1%) to 84.623% when pulling 909b1df4d19c7383b1118c5637874fb3bdd18659 on akonkol:relabel-oauth into dc6551e5844d20a9da69e97c19afa8234f292d41 on discogs:master.

vreon commented 4 years ago

Hi, thank you for opening this pull request.

Unfortunately, this project is no longer actively maintained, and today, we're archiving the repository and publishing the final version to PyPI.

We sincerely appreciate your contribution and regret that we weren't able to give it the attention it deserved.