search

discogs / discogs_client

DEPRECATED - Official Python Client for the Discogs API
http://www.discogs.com/developers
Other
480 stars 132 forks source link

Fixes #82 - Exposes X-Discogs-Ratelimit-Remaining header #89

Closed doomb0t closed 4 years ago

doomb0t commented 6 years ago

I don't really think it should be the job of the client to limit the request rate, since the API actually does this already. But, it is worth exposing the remaining requests. If this means we should open another issue I am happy to do so.

I could expose the other ratelimit headers easily if this is preferable.

Also, I chose to only add the attribute after a request has been made, rather than add it to the base fetcher class with statically coded value like None or 60 I felt it's better to let the api handle that.

Thanks for your time!

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.9%) to 84.369% when pulling aeacb5594178bd71157948e1f9e9ceb7166a337c on VoyagerPunk:issue82 into dc6551e5844d20a9da69e97c19afa8234f292d41 on discogs:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.9%) to 84.369% when pulling aeacb5594178bd71157948e1f9e9ceb7166a337c on VoyagerPunk:issue82 into dc6551e5844d20a9da69e97c19afa8234f292d41 on discogs:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.9%) to 84.369% when pulling aeacb5594178bd71157948e1f9e9ceb7166a337c on VoyagerPunk:issue82 into dc6551e5844d20a9da69e97c19afa8234f292d41 on discogs:master.

alifhughes commented 4 years ago

Bump, is this going to be included/merged?

vreon commented 4 years ago

Hi, thank you for opening this pull request.

Unfortunately, this project is no longer actively maintained, and today, we're archiving the repository and publishing the final version to PyPI.

We sincerely appreciate your contribution and regret that we weren't able to give it the attention it deserved.