discogs / discogs_client

DEPRECATED - Official Python Client for the Discogs API
http://www.discogs.com/developers
Other
479 stars 132 forks source link

Increase test coverage for network request fetchers #90

Closed doomb0t closed 4 years ago

doomb0t commented 6 years ago

I noticed there aren't any tests for the fetchers which make calls to the api, this can be done by using wsgi_intercept to intercept network requests and then returning statically coded responses much like you do currently with the other fetchers. At Adblock Plus we use wsgi_intercept in couple test suites like here and here. Even though we are using pytest it shouldn't be a problem to do this with unittest/nose and I would be happy to implement the tests and intercepts as well.

vreon commented 4 years ago

Hi, thank you for opening this issue.

Unfortunately, this project is no longer actively maintained, and today, we're archiving the repository and publishing the final version to PyPI.

We sincerely appreciate your contribution and regret that we weren't able to give it the attention it deserved.