search

discogs / pymongo-job-queue

MongoDB-based message queue
https://pypi.python.org/pypi/pymjq
MIT License
19 stars 20 forks source link

Fix coverage badge in README #5

Closed accraze closed 8 years ago

accraze commented 8 years ago

For some reason the coverage badge isn't working anymore, but the repo is still on codecov: https://codecov.io/github/discogs/pymongo-job-queue

shiv4nsh commented 8 years ago

Is this a private one, like do you have any token for this like in this url: https://img.shields.io/codecov/c/token/YOURTOKEN/github/codecov/example-python.svg

accraze commented 8 years ago

@shiv4nsh nope it's not private

insomnious0x01 commented 8 years ago

From the README.md file I picked up this image URL which leads you to the "coverage|unknown". I looked at other repositories that use similar badges and their badges work because they committed changes to their code within last 6 months.

Last commit that was picked up by codecov was "Removed sites property from Job example in README 39b271c" which is 2 commits behind this repo. I've read that codecov only reads your source code when you send a request for them to look at your repository. I've never used codecov before - how do you send them a request so they look at your repo? Is it part of Travis' build script?

feldoh commented 8 years ago

I don't think it's that I've forked it and set up a parallel pipeline to my own account and it's not working even after I upload stuff.

feldoh commented 8 years ago

haha, I worked it out; pr incoming.

feldoh commented 8 years ago

PR #7 Resolves this issue. It seems to be because the coverage combine blanks out the results then the upload shortcuts to no-op because there is no data. As you can see my PR triggered a codecov comment which is as good a test as any and indeed the version of the badge for my PR seems to work: codecov

accraze commented 8 years ago

resolved by #7, thanks everyone!