search

discohook / site

The easiest way to build and send Discord messages using webhooks
https://discohook.app
GNU Affero General Public License v3.0
378 stars 128 forks source link

Update README.md, explain running container, specify node 16 #102

Closed b-rad15 closed 1 year ago

b-rad15 commented 1 year ago

Update README.md to explain running via published container and specified node version 16 to match the version used by the CI image

Wanted to try and make this as simple as possible for people to self host in the event the site ever goes down

maddysrc commented 1 year ago

Probably long overdue so thanks, but why -t?

b-rad15 commented 1 year ago

Without that there isn't color output, at least for podman desktop's logs and windows terminal. Not much but does something.

maddysrc commented 1 year ago

I wouldn't exactly colour output important, especially considering it can mess with output.

b-rad15 commented 1 year ago

Ah ok, have never had output messed up by it (except for piping of course, but if you're doing that you probably know well enough to not use -t). If it can mess up something then yeah may as well leave it off.

maddysrc commented 1 year ago

but if you're doing that you probably know well enough to not use -t

I don't agree, people generally struggle parsing what container technology even means and launch args like --tty is only going to confuse.

b-rad15 commented 1 year ago

Agree to disagree I guess. I think errors in obvious red for random users is more important than possibly having advanced users have to debug why not to use -t, but if you think it's better to not have -t there then feel free to change it. Either way it's not a huge difference.