search

disconnectme / disconnect

Disconnect is a browser extension that makes the web faster, more private, and more secure.
https://disconnect.me/
GNU General Public License v3.0
781 stars 136 forks source link

added jquery source map to chrome manifest #219

Closed dy-dx closed 10 years ago

dy-dx commented 10 years ago

Chrome dev console is spitting out this error again:

Denying load of chrome-extension://ekmfaeljlmjncfnpfehgdhglekkblbga/scripts/vendor/jquery/jquery-2.0.3.min.map. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.

Adding the .map file to the manifest fixes the problem.

oldestlivingboy commented 10 years ago

Thanks! I'd committed (https://github.com/disconnectme/disconnect/commit/24096d356dd7517119a9c2be4362880bf54207bd) then reverted (https://github.com/disconnectme/disconnect/commit/86de61c6297fee84445b963812ac3a269a83db1c) this change earlier because we need to test to make sure there aren't permissioning issues as a result.

jessicabrodsky commented 10 years ago

This seems to be happening again. Reported by user:

"Receiving following error message:

Denying load of chrome-extension://jeoacafpbcihiomhlakheieifhpjdfeo/scripts/vendor/jquery/jquery-2.0.3.js. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by pages outside the extension.

I found the following:

When you don't use jQuery from CDN (you download jQuery for yourself, then include it), it will failed to find its source map, to fix this error download jquery source map."

oldestlivingboy commented 10 years ago

This issue is definitely resolved. The user probably has an old version of Disconnect. Make sure they have the latest, 5.11.0, from https://chrome.google.com/webstore/detail/disconnect/jeoacafpbcihiomhlakheieifhpjdfeo.

jessicabrodsky commented 10 years ago

The user responded:

"I am running 5.11.0.

To reproduce using Win 8.1

Launch chrome from desktop Start chrome debugger. Browse to www.google.com"

oldestlivingboy commented 10 years ago

Tested on same setup, no error.

ghost commented 10 years ago

I can confirm that this error is thrown with 5.11.0 w/ Chrome Version 32.0.1700.77 OS X 10.9

oldestlivingboy commented 10 years ago

We can't reproduce this error on any machine. Disconnect is open source, though, so please submit a patch if you can track down the cause: