Maintain anchor link functionality regardless of onclick code

disconnectme / disconnect

Disconnect is a browser extension that makes the web faster, more private, and more secure.

https://disconnect.me/

GNU General Public License v3.0

780 stars 137 forks source link

Maintain anchor link functionality regardless of onclick code #302

Open iamEAP opened 10 years ago

iamEAP commented 10 years ago

Looks like if you have a regular link that happens to have analytics code in a hard-coded onclick attribute, the link will fail to open when clicked. For example:

<a href="path/to/place" onclick="_gaq.push(['_link', this.href]); return false;" target="_blank">Anchor text</a>

I assume this is not desired behavior.

carbureted commented 10 years ago

Agreed - I've been experimenting with inserting surrogate scripts (similar to the way NoScript does it), and it seems like this will fix a lot of broken links.