search

disconnectme / disconnect

Disconnect is a browser extension that makes the web faster, more private, and more secure.
https://disconnect.me/
GNU General Public License v3.0
777 stars 137 forks source link

Disconnect no longer works in Safari 9 #350

Open CalMlynarczyk opened 8 years ago

CalMlynarczyk commented 8 years ago

I have tried running the extension from both the installed version and the development version, and am seeing this issue in both cases. Both show Disconnect at version 3.0.3. I have experienced this throughout the duration of the OS X 10.11 open beta, and now after installing the GM candidate, I am still not able to get the extension to do anything. It worked fine on Safari 8 under OS X 10.10.

The button no longer displays the icon or does anything when you click on it (although the tooltip is there on hover): button

I briefly scanned through port.js and noticed that it is referencing properties on the safari.extension object that are not there. The only one Safari 9 has is the baseURI property. safari-extension

I did not do any other investigation for the time being; perhaps this property object concern is actually a non-issue.

ys-chung commented 8 years ago

This is going to be a big problem when El Capitan is released.

tbastos commented 8 years ago

:+1: El Capitan was released, this is already a big problem

tomasko126 commented 8 years ago

@CalMlynarczyk @alphachung @tbastos I've decided to make some changes (https://github.com/disconnectme/disconnect/pull/352) in the Disconnect's code today and have been able to make it (finally!) working :) If you wish to install fixed version of Disconnect, just download the .safariextz file from here => click on View button, then on Raw button and installation file will begin to download (but before that, uninstall your existing installation of Disconnect from Safari).

CalMlynarczyk commented 8 years ago

On a related note, is there a policy towards using browser-specific APIs in Disconnect (ex. the content-blocking API in Safari 9)?