disconnectme / disconnect

Disconnect is a browser extension that makes the web faster, more private, and more secure.
https://disconnect.me/
GNU General Public License v3.0
777 stars 137 forks source link

Disconnect can only be used if its item is already placed at startup #357

Open Quicksaver opened 8 years ago

Quicksaver commented 8 years ago

There are many scenarios that lead to an empty Disconnect panel (when clicking its toolbar button):

I was going to create a simple pull request that calls Disconnect.initialize() through a simple CustomizableUI listener every time the Disconnect item is placed in a toolbar node, so that it's sure to exist then and the initialization process can finish. But by then it has surely run at least once, and there is just so much going on in that initialize method that I don't know if it can be called multiple times or not (I'm guessing not because things get weird if I call it multiple times through the console).

So there needs to be a flag somewhere that controls whether the button/panel have been initialized yet for this to work properly.