search

disconnectme / search

Disconnect Search is a browser extension that lets you search privately using your favorite search engine.
https://disconnect.me/search
58 stars 12 forks source link

Ctrl+click does not work to open link in new tab on search.disconnect.me #42

Open psivesely opened 10 years ago

psivesely commented 10 years ago

For that matter neither does the command you use with the VimFX extension to open a link in a new tab. It opens in the current tab unless you right click and then select "open link in new tab."

posita commented 9 years ago

This doesn't work on OS X either (where it's command-click). To reproduce:

  1. Install the latest version of Firefox on OS X (I'm using Mavericks)
  2. Open Firefox and go to http://home.mcom.com/home/welcome.html
  3. Revel in the nostalgia :tada:
  4. Hold down the command (⌘) key and click on any link there
  5. Note that the link is opened in a new tab
  6. Install disconnect search for netscape vintage home page
  7. Hold down the command (⌘) key and click on any of the search results

Expected Results

That the target result would be opened in a new tab just like every other web page on the planet.

Actual Results

The target replaces the search page.

Super Annoying Work-Around

You can still right-click or ctrl-click the link and choose Open Link in New Tab from the context menu, but this is much more cumbersome.

posita commented 9 years ago

Possible duplicate of #35 (open for more than a year)? :disappointed:

psivesely commented 9 years ago

This is actually not the source code for search.disconnect.me, it is the source code for Disconnect Search add-on for Firefox and Chromium.

posita commented 9 years ago

This is actually not the source code for search.disconnect.me, it is the source code for Disconnect Search add-on for Firefox and Chromium.

@fowlslegs, I'm aware of that. When the Disconnect plugins _aren't_ installed, and one merely conducts a search via https://search.disconnect.me/, command-click works as expected to open a new tab.

psivesely commented 9 years ago

Okay, if you wish you can add search.disconnect.me directly to your FF search engines. If you right click on the address bar you should find the option. This will be easier on your memory and is more convenient IMO.

posita commented 9 years ago

@fowlslegs, do you have edit permissions on this issue? If so, I would suggest labeling (and possibly closing) this and #35 as wontfix (or the equivalent) to let others know that the browser plugins won't be updated.

Also, I'm not sure what I should expect to see when right-clicking the address bar, but I believe recent versions of Firefox require special definitions for adding a search engine (e.g., via OpenSearch). Looking at the source of https://search.disconnect.me/, it doesn't appear that Disconnect provides one. I tried making one, but apparently my plugin fu is inferior. :disappointed:

UPDATE: It turns out at least three people beat me to publishing a Disconnect OpenSearch plugin (or equivalent).