search

discontinue / django-dbpreferences

:rotating_light:currently unmaintained:rotating_light: A reuseable django app for storing preferences into database.
Other
12 stars 4 forks source link

merge... #5

Closed jedie closed 9 years ago

jedie commented 9 years ago

I would like to merge all your changes...

@robromano : Can you move them into a branch? e.g.: "develope"

see also: https://github.com/jedie/django-dbpreferences/issues/4

robromano commented 9 years ago

Sure, python 3 support not yet ready.

On Mon, Oct 20, 2014 at 8:24 AM, Jens Diemer notifications@github.com wrote:

I would like to merge all your changes...

@robromano https://github.com/robromano Can you move them into a branch? e.g.: "develope"

see also: #4 https://github.com/jedie/django-dbpreferences/issues/4

You can merge this Pull Request by running

git pull https://github.com/robromano/django-dbpreferences master

Or view, comment on, or merge it at:

https://github.com/jedie/django-dbpreferences/pull/5 Commit Summary

  • Updates for Django 1.6+, add Travis
  • try python 3.3 support
  • Python 3 support
  • Remove Django 1.7 test from matrix
  • fix print stmt for python 3
  • more python 3 fixes
  • more python 3 fixes
  • more python 3 fixes
  • more python 3 fixes
  • more python 3 fixes
  • Add six for python2/3 compatible use of isinstance with unicode or str types.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/jedie/django-dbpreferences/pull/5.

jedie commented 9 years ago

Oh... Wow... I started py3 support and forgot your work here :(

robromano commented 9 years ago

Oops. Hope my stuff is there that you can look at. Or feel free to let me know where I can help out.

On Thursday, June 11, 2015, Jens Diemer notifications@github.com wrote:

Oh... Wow... I started py3 support and forgot your work here :(

— Reply to this email directly or view it on GitHub https://github.com/jedie/django-dbpreferences/pull/5#issuecomment-111169572 .

jedie commented 9 years ago

There is more work needed to support Python 3 and django 1.7...

I merged your work and create a new branch:

https://github.com/jedie/django-dbpreferences/compare/py3%2Bdjango17

So i will close this pull request, but here we can continue talking ;)