discord-diabetes / diabot-plugins

(preserved for posterity) Diabetes-related plugins for supybot
5 stars 2 forks source link

Editing the FAQ Page #11

Closed trippingbackward closed 11 years ago

TwelveBaud commented 11 years ago

Looks good, thanks for the update! :smile:

Couple of nits:

  1. You changed 10:36PM (22:36) to 11:36 on some lines in bgoops's docs but not others.
  2. Previously, the documentation for wiki was manually wrapped per-word. Now that it's been unwrapped, most browsers will try to wrap it by letter: wiki
  3. Not sure precisely why, but expanding bgoops collapses lastbgs. No other accordion behaves this way.
  4. Although it sucks at this, my editor tries to keep lines below 120-140 characters wide, and GitHub only displays the first 125 characters (120 in diffs). Keeping lines short enough to keep on screen is helpful.

Again, nice work, and thanks for not forgetting this like I did.

trippingbackward commented 11 years ago

For problem #3, I realized the problem right when I merged. It's a forgotten < / d i v > that I have already corrected and yet to commit.

trippingbackward commented 11 years ago

Fixed #1 as well with a new commit.